-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update component versions for CAPI, Kind, and other dependencies #383
Conversation
/hold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 20.37% 25.63% +5.25%
==========================================
Files 17 19 +2
Lines 1212 1303 +91
==========================================
+ Hits 247 334 +87
- Misses 965 969 +4 ☔ View full report in Codecov by Sentry. |
/retest |
This is the underlying failure before the CI build cluster upgrade
Next week we are planning on adding a new build cluster to prow that's a EL9 NKE-X which shouldn't have this issue. |
9bbdd57
to
4d037c8
Compare
/hold cancel |
59074fb
to
9dccdc7
Compare
/test e2e-capx-conformance |
/test e2e-k8s-upgrade |
/test e2e-capx-controller-upgrade |
9dccdc7
to
4c3a439
Compare
/retest |
/hold |
4c3a439
to
bffca74
Compare
- Move from k8s.io/utils/pointer to k8s.io/utils/ptr as pointer will be deprecated in the coming release.
/retest |
/test e2e-capx-conformance |
the PE credentials had expired causing CSI failures and had to be rotated. |
/hold cancel |
7c40df7
to
bb65336
Compare
bb65336
to
56e6a3c
Compare
/retest |
/retest |
/test e2e-k8s-conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm /approve
Now that our EL9 build clusters are up and running and we can use newer versions of kind to spin up bootstrap cluster, we can finally update the CAPI, Kind, and other component versions in our toolchain.
Due to modification of versions certain small code changes had to account for new constants and function signatures in newer dependencies. However that triggered failures in our codecov as a lot of these changes were in main.go. As a result, main.go had to be refactored to be more unit-testable to increase code coverage to hit the patch coverage prerequisite.
Note:
--metrics-bind-address
flag has been removed and--diagnostics-address
and--insecure-diagnostics
have been added instead.How has this been tested?