Mark v1alpha4 CRDs as Deprecated and Unserved #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/crd/bases/infrastructure.cluster.x-k8s.io_nutanixclusters.yaml
Outdated
Show resolved
Hide resolved
|
/hold |
thunderboltsid
force-pushed
the
jira/krbn-8069
branch
from
9de85e0 to
d7437d8
Compare
CAPI v1.6 has v1alpha4 types marked as deprecated and unserved. To stay in sync, we are doing the same. With v1.7 these will be removed entirely and we will follow suit when we update to v1.7.
thunderboltsid
force-pushed
the
jira/krbn-8069
branch
from
d7437d8 to
434001a
Compare
|
/hold cancel |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
|
/retest |
yannickstruyf3
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAPI v1.6 has v1alpha4 types marked as deprecated and unserved. To stay in sync, we are doing the same. With v1.7 these will be removed entirely and we will follow suit when we update to v1.7.