Add variable for setting failureDomains on Cluster #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
3 times, most recently
from
4919e44 to
979601e
Compare
deepakm-ntnx
previously approved these changes
Mar 15, 2024
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
from
979601e to
1282eed
Compare
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
3 times, most recently
from
2730416 to
63b8ec4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
from
63b8ec4 to
75cd8b8
Compare
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
3 times, most recently
from
93e4867 to
35290ca
Compare
thunderboltsid
changed the title
thunderboltsid
force-pushed
the
jira/krbn-8065
branch
from
3ea2017 to
881eeba
Compare
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
from
35290ca to
f1b79c8
Compare
thunderboltsid
dismissed
deepakm-ntnx’s stale review
The base branch was changed.
thunderboltsid
force-pushed
the
jira/krbn-8063
branch
from
a02d4b2 to
47dbd30
Compare
|
/retest |
|
/test e2e-k8s-conformance |
deepakm-ntnx
approved these changes
Mar 22, 2024
Also added a test suite for testing clusterclass patches along with a test for failure domains. We can use this test suite to add further tests for testing cluster class patches.
deepakm-ntnx
force-pushed
the
jira/krbn-8063
branch
from
47dbd30 to
b28549d
Compare
dkoshkin
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use conditional presence of failureDomain to apply two patches
The PR also adds a template-test make target which triggers a test that is used to verify that clusterclass patches have the behaviour we expect. This spins up a kind cluster but is not a e2e test as no real underlying infrastructure resources are created. This is not a unit test either as it doesn't exercise any actual code in CAPX. The PR also adds template-test to the GitHub action to integrate it in CI toolchain.