fix: set the kube-vip var to default value instead of env for clusterclass #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
previously approved these changes
Apr 2, 2024
deepakm-ntnx
changed the title
deepakm-ntnx
force-pushed
the
jira/krbn-8114
branch
from
9c3965c to
1a7cd69
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
deepakm-ntnx
force-pushed
the
jira/krbn-8114
branch
from
1a7cd69 to
411da7e
Compare
deepakm-ntnx
force-pushed
the
jira/krbn-8114
branch
from
411da7e to
f9e5226
Compare
|
/retest |
dkoshkin
approved these changes
Apr 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakm-ntnx, dkoshkin, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
waiting for tests to pass before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for timebeing am going to reset these variables to false as default so that kube-vip with CAREN can be up .
Future
once we add above things, we can make them configurable