Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick PR #416 to release-v1.2 #423

Merged
merged 1 commit into from
May 2, 2024
Merged

Cherry-pick PR #416 to release-v1.2 #423

merged 1 commit into from
May 2, 2024

Conversation

thunderboltsid
Copy link
Contributor

Cherry-Pick Details

@thunderboltsid thunderboltsid removed the request for review from tuxtof April 29, 2024 19:35
@thunderboltsid thunderboltsid force-pushed the jira/krbn-8105 branch 2 times, most recently from b71375b to a4a46bd Compare May 2, 2024 13:23
@codecov Codecov
Copy link

codecov bot commented May 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.62%. Comparing base (b74ab58) to head (ee6d4dc).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-v1.2    #423      +/-   ##
===============================================
+ Coverage          9.28%   9.62%   +0.33%     
===============================================
  Files                10      10              
  Lines              1335    1340       +5     
===============================================
+ Hits                124     129       +5     
  Misses             1211    1211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-conformance
/test e2e-k8s-upgrade
/test e2e-nutanix-features

@thunderboltsid
Copy link
Contributor Author

/test e2e-nutanix-features

@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-upgrade

adiantum
adiantum approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

nutanix-cn-prow-bot bot commented May 2, 2024 •
edited
Loading

@thunderboltsid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-capx-controller-upgrade ba08611 link false /test e2e-capx-controller-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Explicitly set a exponential backoff rate limiter for controller conf…
ee6d4dc 
…ig (#416)

The rate limiter base delay and max delay values can be configured using
flags. The default values are 500ms for base delay and 15min for max delay.
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

✅ None of your dependencies violate policy!

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-conformance
/test e2e-k8s-upgrade
/test e2e-nutanix-features

@thunderboltsid
Copy link
Contributor Author

/retest

deepakm-ntnx
deepakm-ntnx reviewed May 2, 2024
View reviewed changes
main.go Show resolved Hide resolved
@thunderboltsid thunderboltsid merged commit 52f3f8c into release-v1.2 May 2, 2024
10 of 11 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8105 branch May 2, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakm-ntnx deepakm-ntnx deepakm-ntnx approved these changes

@adiantum adiantum adiantum approved these changes

@dkoshkin dkoshkin Awaiting requested review from dkoshkin

Assignees

@adiantum adiantum

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thunderboltsid @adiantum @deepakm-ntnx