Cherry-pick PR #415 to release-v1.3 #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
force-pushed
the
jira/krbn-8098
branch
from
0b7ad5d to
e71143c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v1.3 #433 +/- ##
================================================
+ Coverage 16.58% 16.90% +0.32%
================================================
Files 21 22 +1
Lines 2129 2118 -11
================================================
+ Hits 353 358 +5
+ Misses 1776 1760 -16 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepakm-ntnx
approved these changes
May 14, 2024
* Introduce a nutanix prism client cache The cache stores a prismgoclient.V3 client instance for each NutanixCluster instance. The cache is shared between nutanixcluster and nutanixmachine controllers. * Address review comments
Changes to fix linting issues and version dependencies to keep the build passing
thunderboltsid
force-pushed
the
jira/krbn-8098
branch
from
e71143c to
4e6a653
Compare
|
/retest |
✅ None of your dependencies violate policy! |
deepakm-ntnx
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick Details
The changes also include changes to build files and dependencies that allow us to get builds working in this release train with the new changes.