Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #439 to release-v1.3 #442

Merged
merged 1 commit into from
May 31, 2024
Merged

Cherry-pick PR #439 to release-v1.3 #442

merged 1 commit into from
May 31, 2024

Conversation

thunderboltsid
Copy link
Contributor

Cherry-Pick Details

Copy link

✅ None of your dependencies violate policy!

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.84%. Comparing base (b81cb37) to head (f6fc8ee).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-v1.3     #442   +/-   ##
=============================================
  Coverage         17.84%   17.84%           
=============================================
  Files                22       22           
  Lines              2146     2146           
=============================================
  Hits                383      383           
  Misses             1763     1763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tuxtof tuxtof merged commit 452ad29 into release-v1.3 May 31, 2024
8 of 13 checks passed
@tuxtof tuxtof deleted the issue/sweet32 branch May 31, 2024 17:21
@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid added the bug Something isn't working label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants