Remove listMapKey for subnets list in failure domains
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subnet can either be referenced as a UUID or as Name depending on the type of the reference. As a result we can't rely on either of them as a defacto map key.
dkoshkin
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Yep, I had a similar comment nutanix-cloud-native/cluster-api-runtime-extensions-nutanix#684 (comment), didn't realize we had it in CAPX already.
Thanks for removing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 31.74% 31.74%
=======================================
Files 14 14
Lines 1367 1367
=======================================
Hits 434 434
Misses 933 933 ☔ View full report in Codecov by Sentry. |
yannickstruyf3
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subnet can either be referenced as a UUID or as Name depending on the type of the reference. As a result we can't rely on either of them as a defacto map key.