-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): Optimize logic for detach VG from VM for cases with large number of VGs #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tates The polling will now fail after 1 minute or if task returned has a terminal state of FAILED or CANCELLED.
thunderboltsid
requested review from
jimmidyson
and removed request for
adiantum and
yannickstruyf3
August 25, 2024 02:04
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 32.56% 33.00% +0.43%
==========================================
Files 17 17
Lines 1833 1809 -24
==========================================
Hits 597 597
+ Misses 1216 1192 -24
Partials 20 20 ☔ View full report in Codecov by Sentry. |
jimmidyson
reviewed
Aug 25, 2024
jimmidyson
reviewed
Aug 25, 2024
jimmidyson
approved these changes
Aug 25, 2024
faiq
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We optimize the logic and add some guardrails