Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace corev1.ObjectReference with corev1.LocalObjectReference wherever possible #322

Closed
dlipovetsky opened this issue Jan 26, 2024 · 0 comments · Fixed by #332
Closed

Replace corev1.ObjectReference with corev1.LocalObjectReference wherever possible #322

dlipovetsky opened this issue Jan 26, 2024 · 0 comments · Fixed by #332

Comments

@dlipovetsky
Copy link
Contributor

The unit of work is a cluster, and all references following from it should be in the same namespace. A valid corev1.ObjectReference requires a non-empty namespace field, which requires more work (e.g. validation), and creates opportunities for error.

Similar work:
@dlipovetsky dlipovetsky mentioned this issue Jan 26, 2024
Merged
jimmidyson added a commit that referenced this issue Feb 6, 2024
@jimmidyson
fix: Ensure registry credentials are namespace local to Cluster
37b96b8 
Using `LocalObjectReference` ensures user cannot override the secret namespace.

Fixes #322.
@jimmidyson jimmidyson mentioned this issue Feb 6, 2024
Merged
jimmidyson added a commit that referenced this issue Feb 6, 2024
@jimmidyson
fix: Ensure registry credentials are namespace local to Cluster (#332)
861cbdd 
Using `LocalObjectReference` ensures user cannot override the secret
namespace.

Fixes #322.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dlipovetsky