Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list correct registry.k8s.io/sig-storage/csi-snapshotter image #943

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Oct 14, 2024

What problem does this PR solve?:
The current process returns an incorrect image registry.k8s.io/sig-storage/csi-snapshotter:v3.0.3

From the CSI helm chart, we need to set this capability snapshot.storage.k8s.io/v1 to get the correct image.

  snapshotter:
    image: registry.k8s.io/sig-storage/csi-snapshotter:v6.3.3
    imageBeta: registry.k8s.io/sig-storage/csi-snapshotter:v3.0.3
          {{- if .Capabilities.APIVersions.Has "snapshot.storage.k8s.io/v1" }}
          image: {{ .Values.sidecars.snapshotter.image }}
          {{- else }}
          image: {{ .Values.sidecars.snapshotter.imageBeta }}
          {{- end }}

Ran this locally:

make list-images | grep "registry.k8s.io/sig-storage/csi-snapshotter"
registry.k8s.io/sig-storage/csi-snapshotter:v6.3.3

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin requested review from jimmidyson and faiq October 14, 2024 15:43
@dkoshkin dkoshkin self-assigned this Oct 14, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 14, 2024
@jimmidyson jimmidyson enabled auto-merge (squash) October 14, 2024 20:52
@jimmidyson jimmidyson merged commit 91272db into main Oct 15, 2024
26 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/list-csi-snapshotter-image branch October 15, 2024 13:07
@dkoshkin dkoshkin mentioned this pull request Oct 15, 2024
jimmidyson pushed a commit that referenced this pull request Oct 15, 2024
🤖 I have created a release *beep* *boop*
---


## 0.18.0 (2024-10-15)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Add feature-gates plumbing by @jimmidyson in
#919
* feat(api): Add kubernetes version to coredns version mapping by
@thunderboltsid in
#939
### Fixes 🔧
* fix: Shorten readiness probe period to try to prevent races by
@jimmidyson in
#930
* fix: Rename webhook container to manager by @jimmidyson in
#932
* fix: list correct registry.k8s.io/sig-storage/csi-snapshotter image by
@dkoshkin in
#943
* fix: include kube-vip image in generated caren-images.txt by @dkoshkin
in
#940
### Other Changes
* test(e2e): Add v1.30.5 test for Nutanix by @thunderboltsid in
#931
* build: Enable building binary only on macos by @jimmidyson in
#918
* build(deps): Update clusterctl binary to v1.8.3 by @thunderboltsid in
#929


**Full Changelog**:
v0.17.0...v0.18.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants