-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Virtual IP configuration to set different address/port #986
Conversation
ebad0e3
to
f9b6bd0
Compare
f9b6bd0
to
e4e2d76
Compare
...i-runtime-extensions-nutanix/templates/virtual-ip/kube-vip/manifests/kube-vip-configmap.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dkoshkin Do we know of other providers that would need to support this? If not, then I wonder if we should make it specific to Nutanix clusters somehow. |
pkg/handlers/generic/mutation/controlplanevirtualip/providers/providers.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually just realised that Nutanix CCM handler will need updating in https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/pkg/handlers/generic/lifecycle/ccm/nutanix/handler.go to pass in this VIP as well to be ignored as part of possible node IPs by Nutanix CCM.
f04799b
to
dae3dae
Compare
dae3dae
to
9f3c8f7
Compare
What problem does this PR solve?:
New configuration to support setting different virutalIP address from the external controlPlaneEndpoint. This is useful for Clusters like a Nutanix Cluster in a VPC where the virtual IP needs to be some IP from same Subnet as the VMs, but the conrtol-plane endpoint is a floating IP mapped to the virtual IP accessible from outside the VPC.
The "configuration" keyword comes from an existing API here
cluster-api-runtime-extensions-nutanix/api/v1alpha1/addon_types.go
Line 260 in 8e2b307
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Assigned a floating IP
10.22.198.34
to an internal IP172.16.0.101
One of the control-plane VMs got the internal VIP assigned.
And the Cluster is accessible outside of the VPC.
Special notes for your reviewer: