Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable nutanix self hosted e2e tests #987

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

supershal
Copy link
Contributor

@supershal supershal commented Dec 4, 2024

What problem does this PR solve?:
The self hosted tests requires the capi-controllers and caren-controller to move to the workload cluster.
The local caren images created during build are not available to the workload cluster's nodes.

  • allow CI and external users to provide a registry where the local images instead can be pushed and available for worker nodes.
  • Preserves existing defaults of using ko.local for CAREN images if no override is provided.
  • If user want to run self-hosted e2e tests locally they can export LOCAL_IMAGE_REGISTRY=docker.io/<username> and run the tests.
  • Builds local and/or testing image for cluster-api-runtime-extensions-helm-chart-bundle-initializer containers to manage it same way as caren images.

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

The self hosted e2e tests are necessary to enable upgrade e2e tests where cluster is upgraded after its moved.
I will file follow up PRs to enable e2e tests for upgrades.

@supershal supershal marked this pull request as draft December 4, 2024 02:56
@supershal supershal force-pushed the shalin/self-hosted-nutanix branch 5 times, most recently from eb5d5e6 to 7476481 Compare December 5, 2024 04:14
@supershal
Copy link
Contributor Author

Self hosted tests on Nutanix passed: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/actions/runs/12172002359/job/33950079836?pr=987

however the docker self hosted tests are not working on nutanix self hosted dind runners: https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/actions/runs/12172002359/job/33950079615?pr=987
@thunderboltsid can you please help with this. We need to check why docker cluster can't be created on the self hosted dind runners but works on Github hosted ubuntu runners.

@supershal supershal force-pushed the shalin/self-hosted-nutanix branch from 7476481 to 891c6a8 Compare December 5, 2024 23:02
@@ -211,7 +211,7 @@ variables:
# DOCKER_HUB_PASSWORD: ""

intervals:
default/wait-controllers: ["3m", "10s"]
default/wait-controllers: ["10m", "10s"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the helm-repository containers creates PV to store the charts. The PV creation is slow on the nutanix workload cluster. this creates flakes in tests. Increasing timeout to ensure hem-repository comes up.

@@ -98,16 +98,16 @@ jobs:
- {"provider": "Docker", "kubernetesVersion": "v1.29.9"}
- {"provider": "Docker", "kubernetesVersion": "v1.30.6"}
- {"provider": "Docker", "kubernetesVersion": "v1.31.2"}
# Uncomment below once we have the ability to run e2e tests on other providers from GHA.
# - {"provider": "Nutanix", "kubernetesVersion": "v1.29.6"}
- {"provider": "Nutanix", "kubernetesVersion": "v1.30.5", "osImage": "nkp-rocky-9.4-release-1.30.5-20240930171619"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the new 9.5 image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants