Better disconnection handling in main form #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gbakeman
commented
Aug 9, 2022
gbakeman
commented
- Handle disconnections better by separating and centralizing subroutines
- Small modifications to the Pref_Gui to make the main form more responsive to modifications
- Fix two NullReferenceExceptions, in About_Gui and List_Var_Gui
- General code cleanup throughout
- Bumped up reconnect interval for debug mode - Applying code cleaning/simplification to WinNUT.vb - Relocating Properties to near the top of the document - Renamed UPSDisconnect to UPSDisconnectedEvent to better match the purposes of the subroutine. Struggling with the "best" way to handle UPS_Object lifecycle and references
- Cleaned up code in several files - Organized Properties in UPS_Device - PollingInterval is now a property, directly linked to the Timer. - WinNUT_Params: Delay defaults to valid value of 1 - Clarified variable names in Pref_Gui - Raise an even when preferences are saved, and indicate if any were modified - WinNUT.vb: Connect PrefsChanged subroutine to respective event in Prefs_Gui - Simplified connection subroutine - Split off disconnection subroutines for beginning a disconnection, and handling post-disconnect event. Modified the rest of the file to use these subroutines to prevent future null ref exceptions. - Simplified PrefsChanged subroutine for handling changed preferences.
- Also cleaned up code - Ref issue #16
- Also cleaned up code - Ref issue #17
This was
linked to
issues
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.