-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Continuous Integration workflow #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt at this, probably many more to come.
Maybe tabs are an issue? Also tweaked output name.
For when I only need to test something on the website.
Upgrade targeted .Net Framework in AGauge project from 4.0 to 4.7.2 as with the rest of the project. Appears to build fine.
This is a bit unusual. Toasts only work on Windows 10+, so this shouldn't even be compiled then.
…d target Trying to split builds between systems.
And making settings for compiler-defined build for Windows 10 and up.
Feels less hacky than trying to compile in references to random libraries in system folders. Also hoping this means we won't need separate builds for <Windows 10. Fingers crossed this compiles on GitHub. - Added NuGet package reference to Microsoft.Toolkit.Uwp.Notifications 7.1.2 - Reverted compiler ifdefs in favor of the OS check to enable toasts. - Commented out most of the ToastPopup notification class in reference to MS Docs article for sending toasts (see comment on class)
Work around for a set-env deprecated error https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Setup project apparently requires building with devenv. I've no idea if this'll work. Also added an environment variable for the solution file.
Might be able to get away with just specifying the path to the devenv executable. Also forcing build runner to match visual studio version that I'm using.
According to the sample, you don't need quotes for environment variables.
Probably why I was having syntax errors: powershell is the default shell on Windows runners.
It looks like getting the installer to build is more of a headache than I need right now. Reverting all changes back to when I was using msbuild (excluding the environment variable and using the 2019 builder), and building in Debug configuration for now.
Doesn't seem necessary anymore.
MSBuild supports package restoration, let's try that and see if it won't error on the Setup project. Also setting working directory for commands, and removing Setup artifact packaging.
Renaming (git mv'ing) main GUI client project folder for consistency purposes.
Fixing a typo in the solution file that was probably causing an error when trying to find the build output files. Also moving the .editorconfig file to the parent directory.
Trying to tie the build number to the action run amount.
Also trying to learn how to output env variables.
PowerShell tries to start in the project directory (which wasn't checked out yet)
Trying to define it in the workflow now.
Getting closer...?
Could it have been this easy??
Just keep it simple. Also make env var for build output.
Being more descriptive, and troubleshooting
Make relative to working directory
Made variable syntax correct and consistent, also updated the build name to be more descriptive.
Not sure what working-directory is even doing at this point.
Removing unused steps as well.
Making sure to remove the old Win10 configuration from the setup project. Also verify correct release building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an automated build process for WinNUT to ease testing and distribution. See associated issue for more info.