Fix weight saving bug (#209)

* Revert change to weight saving * Update versionCode and versionName
nutritionfactsorg · Aug 18, 2022 · 979e897 · 979e897
1 parent c89d673
commit 979e897
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -39,8 +39,8 @@ android {
         minSdkVersion 16
         targetSdkVersion 30
         vectorDrawables.useSupportLibrary = true
-        versionCode 72
-        versionName "21.2"
+        versionCode 73
+        versionName "21.3"
     }
     buildTypes {
         debug {

diff --git a/app/src/main/java/org/nutritionfacts/dailydozen/model/Weights.java b/app/src/main/java/org/nutritionfacts/dailydozen/model/Weights.java
@@ -64,16 +64,14 @@ public static boolean createWeightsIfDoesNotExist(final Day day, float morningWe
 
         if (weights == null) {
             weights = new Weights(day, morningWeight, eveningWeight);
-        }
-
-        if (weights.morningWeight != morningWeight || weights.eveningWeight != eveningWeight) {
+        } else {
             weights.setMorningWeight(morningWeight);
             weights.setEveningWeight(eveningWeight);
-            weights.save();
-            return true;
         }
 
-        return false;
+        weights.save();
+
+        return true;
     }
 
     public static Weights getWeightsOnDay(final Day day) {

diff --git a/app/src/main/java/org/nutritionfacts/dailydozen/widget/DateWeights.java b/app/src/main/java/org/nutritionfacts/dailydozen/widget/DateWeights.java
@@ -150,10 +150,8 @@ public void onTextChanged(CharSequence s, int start, int before, int count) {
 
                     if (morningWeight > 0 || eveningWeight > 0) {
                         day = Day.createDayIfDoesNotExist(day);
-                        boolean weightSaved = Weights.createWeightsIfDoesNotExist(day, morningWeight, eveningWeight);
-                        if (weightSaved) {
-                            Timber.d("Saving morning weight [%s] and evening weight [%s]", morningWeight, eveningWeight);
-                        }
+                        Weights.createWeightsIfDoesNotExist(day, morningWeight, eveningWeight);
+                        Timber.d("Saving morning weight [%s] and evening weight [%s]", morningWeight, eveningWeight);
                     }
                 } catch (NumberFormatException e) {
                     Timber.e(e);