Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auth providers #12

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Add support for auth providers #12

merged 2 commits into from
Jan 17, 2019

Conversation

wrdls
Copy link
Contributor

@wrdls wrdls commented Jan 16, 2019

I had to update the vendoring because azure gave errors:

make build
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
# github.com/nuvo/orca/vendor/k8s.io/client-go/plugin/pkg/client/auth/azure
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:246:4: cannot use expiresIn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:247:4: cannot use expiresOn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:248:4: cannot use expiresOn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:265:23: cannot use token.token.ExpiresIn (type json.Number) as type string in assignment
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:266:23: cannot use token.token.ExpiresOn (type json.Number) as type string in assignment
make: *** [Makefile:18: vet] Error 2

Note: build fails on my fork because of the imports but I don't have time right now to look into it:

make
dep ensure
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
# github.com/wrdls/orca/pkg/orca
pkg/orca/artifact.go:44:36: not enough arguments in call to utils.PerformRequest
pkg/orca/artifact.go:44:37: undefined: utils.PerformRequestOptions
pkg/orca/artifact.go:94:24: not enough arguments in call to utils.PerformRequest
pkg/orca/artifact.go:94:25: undefined: utils.PerformRequestOptions
pkg/orca/chart.go:59:45: not enough arguments in call to utils.DeployChartFromRepository
pkg/orca/chart.go:59:45: utils.DeployChartFromRepository(composite literal) used as value
pkg/orca/chart.go:59:46: undefined: utils.DeployChartFromRepositoryOptions
pkg/orca/chart.go:123:41: not enough arguments in call to utils.PushChartToRepository
pkg/orca/chart.go:123:41: utils.PushChartToRepository(composite literal) used as value
pkg/orca/chart.go:123:42: undefined: utils.PushChartToRepositoryOptions
pkg/orca/chart.go:123:41: too many errors
# github.com/wrdls/orca/cmd [github.com/wrdls/orca/cmd.test]
cmd/orca.go:72:17: undefined: orca.NewDeployArtifactCmd
cmd/orca.go:100:17: undefined: orca.NewGetArtifactCmd
cmd/orca.go:113:17: undefined: orca.NewLockEnvCmd
cmd/orca.go:126:17: undefined: orca.NewUnlockEnvCmd
cmd/orca.go:165:17: undefined: orca.NewDiffEnvCmd
cmd/orca.go:178:17: undefined: orca.NewValidateEnvCmd
make: *** [Makefile:18: vet] Error 2

#11
kubernetes/client-go#242

@maorfr
Copy link
Contributor

maorfr commented Jan 17, 2019

Hey,

Thanks for this PR!
I would rather not using the master branch for dependencies. For uitable it is not that bad, but for the k8s related, maybe we can use a version?
Would the newest (10? Not sure) work?
If not, can we check release branch 1.13?

Thanks again :)

@wrdls
Copy link
Contributor Author

wrdls commented Jan 17, 2019

Fair enough.

kubernetes-1.12.4 didn't work so I picked kubernetes-1.13.2 which is the latest stable release.

@maorfr
Copy link
Contributor

maorfr commented Jan 17, 2019

Thanks a lot :)
I will merge that in and if all goes well i will tag it as version 0.9.2.

Glad you got involved. Let us know for any questions you have ;)

@maorfr maorfr merged commit 5838406 into nuvo:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants