Compare raw attributes only when ensuring uniqueness of paginated rel…

…ated models
nuwave · May 1, 2024 · dd2b859 · dd2b859
1 parent 3f20ff1
commit dd2b859
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,10 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+### Changed
+
+- Compare raw attributes only when ensuring uniqueness of paginated related models https://github.com/nuwave/lighthouse/pull/2540
+
 ## v6.36.1
 
 ### Fixed

diff --git a/src/Execution/ModelsLoader/PaginatedModelsLoader.php b/src/Execution/ModelsLoader/PaginatedModelsLoader.php
@@ -12,6 +12,7 @@
 use Nuwave\Lighthouse\Pagination\PaginationArgs;
 use Nuwave\Lighthouse\Pagination\ZeroPerPageLengthAwarePaginator;
 use Nuwave\Lighthouse\Support\Utils;
+use function Safe\json_encode;
 
 class PaginatedModelsLoader implements ModelsLoader
 {
@@ -84,7 +85,7 @@ protected function loadRelatedModels(EloquentCollection $parents): EloquentColle
         return $relatedModels->unique(
             // Compare all attributes because there might not be a unique primary key
             // or there could be differing pivot attributes.
-            static fn (Model $relatedModel): string => $relatedModel->toJson(),
+            static fn (Model $relatedModel): string => json_encode($relatedModel->getOriginal()),
         );
     }