Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html invalid attribute #88

Closed
wants to merge 2 commits into from

Conversation

nicoschi
Copy link

@nicoschi nicoschi commented May 1, 2021

Use data-ie-style instead of ie-style for inline styles in order to pass html validation

nicoschi added 2 commits May 1, 2021 18:09
Use data-ie-style instead of ie-style for inline styles to pass html validation
Use data-ie-style instead of ie-style
@nicoschi nicoschi changed the title Fix/html invalid attribute Fix html invalid attribute May 1, 2021
@nuxodin
Copy link
Owner

nuxodin commented May 2, 2021

Thank you for your PR.
Since custom attributes are well supported, even if not (yet) specified. I would like to keep it that way. Also to remain compatible.

@nuxodin nuxodin closed this May 2, 2021
@nicoschi
Copy link
Author

nicoschi commented May 3, 2021

Is there some documentation about future implementation of html custom attributes by W3C?

@nuxodin
Copy link
Owner

nuxodin commented May 3, 2021

Here is the discussion:
whatwg/html#2271

As I said, it is not specified and may never be specified, but since all browsers allow it, it can be used (carefully).

By the way, "data-" attributes are less intended to be used for independent frameworks, but rather for project-specific data.
https://html.spec.whatwg.org/multipage/dom.html#embedding-custom-non-visible-data-with-the-data-*-attributes

Custom data attributes are intended to store custom data, state, annotations, and similar, private to the page or application,

@nicoschi
Copy link
Author

nicoschi commented May 3, 2021

I know, but sometimes projects require W3C validation. Nevermind, I will use a patched version. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants