Skip to content

Commit

Permalink
fix(meta): add missing hid to icon tags (#428)
Browse files Browse the repository at this point in the history
  • Loading branch information
buoto authored Jan 26, 2021
1 parent 245aadc commit d9addb7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/meta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ export function meta (nuxt, pwa: PWAContext, moduleContainer) {

// Shortcut icon
if (options.favicon) {
head.link.push({ rel: 'shortcut icon', href: iconSmall.src })
head.link.push({ rel: 'apple-touch-icon', href: iconBig.src, sizes: iconBig.sizes })
head.link.push({ hid: 'shortcut-icon', rel: 'shortcut icon', href: iconSmall.src })
head.link.push({ hid: 'apple-touch-icon', rel: 'apple-touch-icon', href: iconBig.src, sizes: iconBig.sizes })
}

// Launch Screen Image (IOS)
Expand Down Expand Up @@ -122,7 +122,7 @@ export function meta (nuxt, pwa: PWAContext, moduleContainer) {
// TODO: Drop support as it is harmful: https://mathiasbynens.be/notes/rel-shortcut-icon
const favicon = join(nuxt.options.srcDir, nuxt.options.dir.static, 'favicon.ico')
if (existsSync(favicon)) {
head.link.push({ rel: 'shortcut icon', href: nuxt.options.router.base + 'favicon.ico' })
head.link.push({ hid: 'shortcut-icon', rel: 'shortcut icon', href: nuxt.options.router.base + 'favicon.ico' })
}
}

Expand Down

0 comments on commit d9addb7

Please sign in to comment.