Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape unsafe key chars #8

Merged
merged 4 commits into from
Apr 14, 2019
Merged

fix: escape unsafe key chars #8

merged 4 commits into from
Apr 14, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 13, 2019

Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for acting quickly on this @pi0

@JohannesLamberts
Copy link

JohannesLamberts commented Apr 13, 2019

@pi0 I tested using the https://codesandbox.io/s/5x2wpo27k4 and the fix looks good to me.

@JohannesLamberts
Copy link

I'd like to cross-reference vuejs/vuex-router-sync#89 and https://www.npmjs.com/advisories/814 here, which should also be fixed by this.

@pi0
Copy link
Member Author

pi0 commented Apr 13, 2019

Something I'm not sure about this is that it may be also a breaking change. Objects like { "foo/bar": "baz" } can be broken. Maybe not something essentially bad as serialize-javascript also does the same.

UPDATE: Only / whitelisted. The case with reported sandboxes still will be prevented.

@pi0 pi0 merged commit ecde7cf into master Apr 14, 2019
@pi0 pi0 deleted the fix/serialize-key branch April 14, 2019 20:43
@pi0 pi0 mentioned this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants