-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add preload
and prefetch
attributes to manifest
#50
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 97.54% 97.55%
=======================================
Files 6 6
Lines 530 532 +2
Branches 112 112
=======================================
+ Hits 517 519 +2
Misses 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We could alternatively entirely remove the shouldPreload/shouldPrefetch and make a major version bump. |
I love it! I think making a mjaor version + removing runtime hooks makes sense because if someone uses resolution in runtime and does not have build-time flags (with new build), it won't work. |
preload
and prefetch
attributes to manifestpreload
and prefetch
attributes to manifest
Let's go for major version then. Though I do think this (as-is) is backwards compatible. (We require manifests to be normalised, not just for this reason.) |
resolves #45
This adds backwards-compatible build-time analysis on whether to prefetch/preload resources.
It should be exactly compatible with current default runtime values as moves the runtime code to build-time (and defers to any custom shouldPrefetch/shouldPreload that is passed).Refactored to be a breaking change.