Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo tokenName is always the same #386

Open
LuXDAmore opened this issue Mar 16, 2021 · 1 comment · May be fixed by #403
Open

Apollo tokenName is always the same #386

LuXDAmore opened this issue Mar 16, 2021 · 1 comment · May be fixed by #403

Comments

@LuXDAmore
Copy link

LuXDAmore commented Mar 16, 2021

Version

v4.0.1-rc.1

Reproduction link

https://codesandbox.io/s/nuxt-apollo-module-token-name-bug-ym7pn

Steps to reproduce

  1. Create a Nuxt project;
  2. Install the module;
  3. Configure 2 different clients;
  4. Use a custom tokenName value per-client.

What is expected ?

It should create differents cookies per-clients.

What is actually happening?

Create only one cookie used by all the clients, with the name 'apollo-token'.

Additional comments?

The version i'm using is the 4.0.1-rc.5, but it's not present in the list.

From the generated file .nuxt/apollo-module.js:

  
  const AUTH_TOKEN_NAME = 'apollo-token';
  const defaultTokenName = ''  || AUTH_TOKEN_NAME;
  const authTokenName = ''  || AUTH_TOKEN_NAME;

  cookies.set( AUTH_TOKEN_NAME, token, cookieAttributes );
  cookies.remove( AUTH_TOKEN_NAME, cookieAttributes );

Every cookie / name is based on the default value and not from the provided tokenName per-client.

This bug report is available on Nuxt community (#c371)
@sgarner sgarner linked a pull request Jun 30, 2021 that will close this issue
@sgarner
Copy link

sgarner commented Jun 30, 2021

I am seeing the same issue.

PR: #403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants