fix: per-client tokenName from config files
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgarner
force-pushed
the
fix/per-client-tokens
branch
from
eee33cd
to
6d64602
Compare
sgarner
changed the title
tokenName from config filestokenName from config files
|
Note that an issue remains with the implementation of I don't see an obvious solution to that since there is no way to relate the passed in Ideas for that welcome, but this PR at least fixes the issue with the wrong token being sent in requests. |
|
BTW the failing build has nothing to do with this PR and looks like it has been broken for a while 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386
When defining multiple apollo clients in external files, the
tokenNamefor each client would not be set correctly in the compiled plugin.This PR changes the template so that the
tokenNameis read after reading the config file instead of before.