Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cssnano on production #171

Closed
wants to merge 1 commit into from

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Dec 8, 2023

Resolve #158 A temporary solution.

Maybe this configuration of cssnano should come by default in nuxt, only in production mode

{
  cssnano: {
    preset: ['default', { discardComments: { removeAll: true } }]
  }
}

wdyt @danielroe

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for pedantic-sinoussi-65c819 canceled.

Name Link
🔨 Latest commit 57d9813
🔍 Latest deploy log https://app.netlify.com/sites/pedantic-sinoussi-65c819/deploys/65731c9c1d97e4000884b6d6

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (9722275) 89.51% compared to head (57d9813) 85.77%.

Files Patch % Lines
src/module.ts 29.41% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   89.51%   85.77%   -3.75%     
==========================================
  Files           1        1              
  Lines         229      246      +17     
  Branches       22       23       +1     
==========================================
+ Hits          205      211       +6     
- Misses         24       35      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardogobbosouza ricardogobbosouza deleted the fix-cssnano-on-production branch March 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like adding font families doenst work in Nuxt 3.8.0 and Netlify
1 participant