Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to latest @nuxt/module-builder #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielroe
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: nuxt/nuxt#28480, nuxt/nuxt#28593
See also nuxt/nuxt#28672.

Copy link

netlify bot commented Aug 25, 2024

βœ… Deploy Preview for pedantic-sinoussi-65c819 canceled.

Name Link
πŸ”¨ Latest commit f5d0cbd
πŸ” Latest deploy log https://app.netlify.com/sites/pedantic-sinoussi-65c819/deploys/66cba4dd43f9a3000873d999

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 67.21%. Comparing base (7099819) to head (f5d0cbd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   67.21%   67.21%           
=======================================
  Files           7        7           
  Lines         305      305           
  Branches       27       27           
=======================================
  Hits          205      205           
  Misses         92       92           
  Partials        8        8           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant