-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure langDir is escaped on Windows #1097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or maybe that's just on my system because I'm forcing a Windows path on MacOS? |
It didn't look so bad. Slashes were mixed (backslashes and standard ones), but they are at least escaped properly. |
rchl
reviewed
Mar 8, 2021
rchl
approved these changes
Mar 8, 2021
rchl
changed the title
fix: langDir path must be escaped on windows
fix: ensure langDir is escaped on Windows
Mar 8, 2021
Thanks! |
This was referenced Mar 9, 2021
Closed
Closed
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating
nuxt-i18n
my project stopped compiling.After some digging, I've found this problem:
I'm working on windows, and paths do use backslashes.
When creating script templates this requires for string to be properly escaped.
It's enough to pass it through
JSON.stringify
, so I think easiest way to fix that, was to remove the special case for string.Also, checking for
boolean
andnull
should also be unnecessary -JSON.stringify
should handle it as well.PS: this would also break if there were
'
characters anywhere inside.