Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types #167

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Update types #167

merged 2 commits into from
Jan 14, 2019

Conversation

iliyaZelenko
Copy link

That's what RawLocation is:

export type RawLocation = string | Location;

export interface Location {
  name?: string;
  path?: string;
  hash?: string;
  query?: Dictionary<string | string[]>;
  params?: Dictionary<string>;
  append?: boolean;
  replace?: boolean;
}

This type, for example, is used in the "push" method:

push (location: RawLocation, onComplete?: Function, onAbort?: ErrorHandler): void;

Without this fix, I had a error:

image

iliyaZelenko and others added 2 commits December 9, 2018 22:58
That's what RawLocation is:

```ts
export type RawLocation = string | Location;

export interface Location {
  name?: string;
  path?: string;
  hash?: string;
  query?: Dictionary<string | string[]>;
  params?: Dictionary<string>;
  append?: boolean;
  replace?: boolean;
}
```
@iliyaZelenko
Copy link
Author

These changes will not spoil anything, but only allow us to use the necessary route object.

@paulgv paulgv merged commit 225e700 into nuxt-modules:master Jan 14, 2019
@paulgv
Copy link
Collaborator

paulgv commented Jan 14, 2019

Thanks @iliyaZelenko !

@iliyaZelenko iliyaZelenko deleted the patch-1 branch July 24, 2019 18:36
farnabaz pushed a commit to farnabaz/i18n-module that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants