feat: experimental feature switchLocalePathLinkSSR with <SwitchLocalePathLink> component
#2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbieGoede
force-pushed
the
feat/switch-locale-path-link-ssr
branch
from
30cc704
to
bdd24fd
Compare
✅ Live Preview ready!
|
BobbieGoede
changed the title
switchLocalePathLink SSR componentswitchLocalePathLinkSSR with <SwitchLocalePathLink> component
BobbieGoede
changed the title
switchLocalePathLinkSSR with <SwitchLocalePathLink> componentswitchLocalePathLinkSSR with <SwitchLocalePathLink> component
kazupon
approved these changes
Mar 14, 2024
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
…alePathLink>` component (nuxt-modules#2838) * feat: `switchLocalePath` ssr * feat: experimental `switchLocalePathLink` SSR component * refactor: use constant for `SwitchLocalePathLinkSSR` component retrieval * test: assert `switchLocalePathLinkSSR` functionality * docs: add documentation for `switchLocalePathLink` component and config * refactor: locale in wrapper comment to reduce regex matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Resolves #2798
This adds a component
SwitchLocalePathLinkwhich is not much different from passingswitchLocalePathtoNuxtLinkexcept the resulting link is wrapped in comments<!--nuxt-i18n-slp-[locale]-->...<!--/nuxt-i18n-slp-->.While
setI18nParamscurrently works, it actually doesn't render the correct links during SSR depending on when and where it is used (as a warning describes in the docs), I have added an experimental feature that aims to resolve this.The following functionality is enabled with the
experimental.switchLocalePathLinkSSRproperty:The
setI18nParamsis changed to use auseStateref instead of thenuxtI18nmeta property on the route, this would normally cause a hydration mismatch (lang switcher rendered beforesetI18nParamsis called, while the client will have the correct data at hydration) which is why we couldn't use this before.Using the wrapping comments to find the links with their locale in the rendered DOM at the end of SSR, the URL is replaced with an up to date localized path returned from
switchLocalePath.The implementation feels hacky to me but it seems to work fine, if there is a better way to do this please let me know!
📝 Checklist