chore: refactor module #3117
Merged
chore: refactor module #3117
+374
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
approving to run ci |
BobbieGoede
reviewed
Sep 20, 2024
|
|
||
| ctx.genTemplate = genTemplate | ||
|
|
||
| nuxt.options.runtimeConfig.public.i18n.locales = simplifyLocaleOptions(nuxt, defu({}, options)) |
There was a problem hiding this comment.
I'm guessing we can't move this to prepare/runtime-config.ts right? 🤔
There was a problem hiding this comment.
oh, we can do what we want here
There was a problem hiding this comment.
we can move runtime config after runtime and then we can move it: do you want me to move it?
BobbieGoede
approved these changes
Sep 20, 2024
kazupon
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
This PR just moves logic from
module.tsto the corresponding module: for example, when configuring nitro, the currentmodule.tswill build theAdditionalSetupNitroParams(being used or not), with the new approach, thenitro.tsmodule will build theAdditionalSetupNitroParamswhen required.The idea is to have the
module.tsto orchestrate the I18n configuration: any shared data should be on the context, and the modules should do their work. Themodule.tswill call the initialization sequence correctly, and modules preparing shared data should add their stuff to the context (checkprepare/locale-info.tsandprepare/runtime.ts).Any module should only accept the context and nuxt as parameters: using destructuring on the context to get used data.
❓ Type of change
📚 Description
📝 Checklist