Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Storybook version from storybook.ts #778

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 18, 2024

🔗 Linked issue

📚 Description

The Storybook versions in the package.json were updated, but the same change needs to be added to the storybook.ts to prevent version conflicts.

Currently, with nightly, we get the following error:

WARN The following packages are incompatible with Storybook 8.2.7 as they depend on different major versions of Storybook packages:
WARN - @nuxtjs/storybook@8.3.0-28764731.a9bf66d
WARN  Repo: https://storybook.nuxtjs.org
WARN - @storybook-vue/nuxt@8.3.0-28764731.a9bf66d
WARN  Repo: https://storybook.nuxtjs.org
WARN - storybook@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/cli
WARN - @storybook/vue3@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/renderers/vue3
WARN - @storybook/addon-links@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/links
WARN - @storybook/builder-vite@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/builders/builder-vite/#readme
WARN - @storybook/addon-essentials@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/essentials
WARN - @storybook/addon-interactions@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/interactions
WARN - @storybook/test@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/test
WARN - @storybook/blocks@8.2.9
WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/blocks
WARN 
WARN 
WARN Please consider updating your packages or contacting the maintainers for compatibility details.
WARN For more on Storybook 8 compatibility, see the linked GitHub issue:
WARN https://github.com/storybookjs/storybook/issues/26031

 ERROR  Storybook failed to load the following preset: @storybook-vue/nuxt/preset.                                                                                                              nuxt:storybook:build 5:37:16 PM

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for nuxt-storybook ready!

Name Link
🔨 Latest commit 670403c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-storybook/deploys/66ed247dae41840008bb7319
😎 Deploy Preview https://deploy-preview-778--nuxt-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tobiasdiez
Copy link
Collaborator

Thanks! Now that storybookjs/storybook#28594 is merged, we should actually be able to simply remove the packageJson. Could you please give this a try? (I can also do this on Friday)

@obulat obulat changed the title fix: update Storybook version in storybook.ts fix: remove Storybook version from storybook.ts Sep 20, 2024
@obulat
Copy link
Contributor Author

obulat commented Sep 20, 2024

Thanks! Now that storybookjs/storybook#28594 is merged, we should actually be able to simply remove the packageJson. Could you please give this a try? (I can also do this on Friday)

I removed the packageJson completely. The CI is passing. Is there anything else that needs to be done?

@tobiasdiez
Copy link
Collaborator

Awesome! Thanks for your continued contributions ❤️

@tobiasdiez tobiasdiez merged commit 3c5e4d3 into nuxt-modules:main Sep 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants