perf: parallelise all async calls #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
ineshbose
commented
May 16, 2023
| configPaths.map(async (configPath, idx, paths) => { | ||
| let _tailwindConfig: Partial<TWConfig> | undefined | ||
| try { | ||
| _tailwindConfig = await import(configPath).then(c => c.default || c) |
There was a problem hiding this comment.
Can append .catch block but not required
There was a problem hiding this comment.
Causing issues in build when TS config is imported into module.mjs
ineshbose
commented
May 16, 2023
atinux
reviewed
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireModuleforawait import()(also parallelised) 🚢