-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #883 Tab view src leading baseURL #885
fix: #883 Tab view src leading baseURL #885
Conversation
Fixed issue nuxt-modules#883: Cannot find any path matching /_tailwind/, when using baseUrl: '/dev/'. Cannot find any path matching '/_tailwind/'
I made a mistak in previous commit forcing default '/' baseURL in front of already existing trailing slash before default `/_tailwind/`. This fix makes sure if baseURL is `/` it removes it and if it has something similar to `/dev/` it with return `/dev`, making final url `/dev/_tailwind/`.
✅ Deploy Preview for nuxt-tailwindcss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Summary
|
I am using nuxt2 and experiencing a smiliar issue. My app tries to handle /_tailwind and loads nuxt instead of the tw viewer. Is this fix only for nuxt3? |
Yes, I think so. As far as I know Nuxt 2 Can you submit your reproduction of the issue in #883? |
@richardevcom Sorry, I think my issue is not directly related to this fix. I opened #886 Please dont mind my comment here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this ❤️ - no way this was missed till this point!
Fixed issue #883:
Cannot find any path matching /_tailwind/
, when usingbaseUrl
:/dev/
.Additionally added conditional
baseURL
output, where if it matches/
it prefixes empty string''
, making final Tab view src always/dev/_tailwind/
(depending onnuxt.config.ts
) or/_tailwind/
.🔗 Linked issue
Issue #883
❓ Type of change
📚 Description
This change is required to fix Tailwind Config Viewer embedded url by appending missing
baseUrl
setting (if set).