Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide nuxt useRoute and useRouter composables #590

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

danielroe
Copy link
Member

This reverts commit 5e5fa50.

πŸ”— Linked issue

resolves #554, nuxt-modules/color-mode#169

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When we switched to using native vue-router composables in #533, we lost support for using useRoute and useRouter in Nuxt plugins, middleware, etc. (ie. anywhere outside of a component). This PR reverts that change in that if called outside a composable it will revert to previous behaviour. However, within a component, we still use the native vue-router composable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ❗ p4-important labels Oct 23, 2022
@danielroe danielroe requested a review from pi0 October 23, 2022 14:25
@danielroe danielroe self-assigned this Oct 23, 2022
@danielroe danielroe merged commit a7b12a3 into main Oct 24, 2022
@danielroe danielroe deleted the fix/router-composables branch October 24, 2022 15:06
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ❗ p4-important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useRouter and useRoute failed when used inside plugin
1 participant