Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression in entrypoint with CDN URL #611

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: regression in entrypoint with CDN URL #611

merged 1 commit into from
Nov 30, 2022

Conversation

IlyaSemenov
Copy link
Contributor

🔗 Linked issue

#580

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes entrypoint-legacy not loading any further modules when the production build is started with NUXT_APP_CDN_URL=https://cdn.url due to .slice(1) mangling the URLs to ttps://cdn.ur/_nuxt/module.js (note the missing h).

Resolves #580.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
Copy link
Member

Thank you ❤️

@danielroe danielroe merged commit 32c4527 into nuxt:main Nov 30, 2022
@danielroe danielroe mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First letter is stripped out from cdnURL option or NUXT_APP_CDN_URL env variable on prod build
2 participants
@IlyaSemenov @danielroe