Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move nuxt 2 context types to bridge-schema #752

Merged
merged 4 commits into from
May 31, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented May 3, 2023

πŸ”— Linked issue

#749

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the following PR, the types for nuxt 2 context have been improved. To avoid dependency on nuxt 2 types, we want to move the necessary types from @nuxt/types and remove them from dependencies.
#749

I tried to create the types as strictly as possible based on the implementation, but some parts that couldn't be done were set to any.
(It's challenging to decide where to place the types for nuxt 2. Would bridge-schema be a more appropriate location?)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
Copy link
Member

Would bridge-schema be a more appropriate location?

Yes, I think that would be perfect πŸ‘

@danielroe danielroe changed the title fix: Remove @nuxt/types from peerDependencies. fix: move nuxt 2 context types to bridge-schema May 31, 2023
@danielroe danielroe merged commit e9f135f into nuxt:main May 31, 2023
@wattanx wattanx deleted the fix-remove-nuxt-types branch June 1, 2023 04:24
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants