-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove nuxi
dependency and prompt to install when needed
#907
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8b454ce
remove: Install nuxi when you want to use nitro
wattanx 2592008
feat: Add nuxi install prompt
wattanx 94246e6
lint fix
wattanx a58c4ec
chore: fixed nuxi version
wattanx da80bb4
feat: support nuxt2 command
wattanx 3d83978
remove: remove prompts
wattanx 4654a52
Merge branch 'main' into fix/change-to-nuxi-optional
wattanx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { addDependency } from 'nypm' | ||
import { resolvePackageJSON } from 'pkg-types' | ||
import { logger } from '@nuxt/kit' | ||
import { isCI } from 'std-env' | ||
import prompts from 'prompts' | ||
|
||
export async function ensurePackageInstalled ( | ||
rootDir: string, | ||
name: string, | ||
searchPaths?: string[] | ||
) { | ||
if (await resolvePackageJSON(name, { url: searchPaths }).catch(() => null)) { | ||
return true | ||
} | ||
|
||
logger.info(`Package ${name} is missing`) | ||
if (isCI) { | ||
return false | ||
} | ||
|
||
const { confirm } = await prompts({ | ||
type: 'confirm', | ||
name: 'confirm', | ||
message: `Do you want to install ${name} package?`, | ||
initial: true | ||
}) | ||
|
||
if (!confirm) { | ||
return false | ||
} | ||
|
||
logger.info(`Installing ${name}...`) | ||
try { | ||
await addDependency(name, { | ||
cwd: rootDir, | ||
dev: true | ||
}) | ||
logger.success(`Installed ${name}`) | ||
return true | ||
} catch (err) { | ||
logger.error(err) | ||
return false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
}, | ||
"devDependencies": { | ||
"@nuxt/bridge": "latest", | ||
"nuxi": "3.7.3", | ||
"nuxt": "^2.17.1" | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly use
consola.prompt
(orlogger.prompt
-- not tested) to avoid new dependency