feat(server-routes): implement persisting input values in localStorage #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6a759d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e6a691a.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://feat-sr-inputs-localstorage.nuxt-devtools.pages.dev |
|
Shall we also remember the active tab for each route? |
|
@atinux For sure! |
|
Looks good to me! I let @antfu do the final review |
antfu
reviewed
Dec 20, 2023
| @@ -308,6 +308,50 @@ watchEffect(() => { | |||
| } | |||
| }) | |||
|
|
|||
| const savedRouteInputs = useLocalStorage<{ path: string, tab: string, inputs: any }[]>('nuxt-devtools:server-routes:inputs', () => [], { | |||
| window: window.parent, | |||
There was a problem hiding this comment.
Is there a reason to pass the parent window here? It should work with iframe window as they are same origin.
There was a problem hiding this comment.
While trying out with my laptop(windows 10), the storage wasn't working as expected(the client would get reset after a page refresh)
Is it possible for you to test it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-12-16.at.9.10.16.PM.mov