Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Improve inject documentation #694

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Improve inject documentation #694

merged 1 commit into from
Aug 9, 2018

Conversation

TheAlexLichter
Copy link
Member

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo changed the base branch from master to 2.0 August 9, 2018 18:31
@clarkdo clarkdo merged commit d6ec210 into nuxt:2.0 Aug 9, 2018
@atinux
Copy link
Member

atinux commented Aug 10, 2018

Wow thank you so much @manniL

@TheAlexLichter
Copy link
Member Author

No problem @atinux ☺️

@doriandrn
Copy link

Thanks for this!
In the latest examples, you have used new which is a reserved word in JS and using it as a value might be confusing for some people. I would really change it to newValue or something similar.

@TheAlexLichter
Copy link
Member Author

@doriandrn Thanks for letting me know! Will fix it up in a minute ☺️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants