fix(eslint-config): do not eagerly import ts-eslint parser, close #485

nuxt · Aug 22, 2024 · 4b5d65c · 4b5d65c · Revadike · Aug 22, 2024
1 parent bbd812e
commit 4b5d65c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/eslint-config/src/flat/configs/typescript.ts b/packages/eslint-config/src/flat/configs/typescript.ts
@@ -4,6 +4,8 @@ import type { Linter } from 'eslint'
 import type { NuxtESLintConfigOptions } from '@nuxt/eslint-config/flat'
 import { resolveOptions } from '../utils'
 
+export { parserTs, pluginTs }
+
 export default function typescript(options: NuxtESLintConfigOptions): Linter.Config[] {
   const resolved = resolveOptions(options)
 

diff --git a/packages/eslint-config/src/flat/configs/vue.ts b/packages/eslint-config/src/flat/configs/vue.ts
@@ -1,6 +1,4 @@
 import * as parserVue from 'vue-eslint-parser'
-import parserTs from '@typescript-eslint/parser'
-
 // @ts-expect-error missing types
 import pluginVue from 'eslint-plugin-vue'
 import type { Linter } from 'eslint'
@@ -10,10 +8,14 @@ import { removeUndefined, resolveOptions } from '../utils'
 // imported from 'eslint-plugin-vue/lib/utils/inline-non-void-elements.json'
 const INLINE_ELEMENTS = ['a', 'abbr', 'audio', 'b', 'bdi', 'bdo', 'canvas', 'cite', 'code', 'data', 'del', 'dfn', 'em', 'i', 'iframe', 'ins', 'kbd', 'label', 'map', 'mark', 'noscript', 'object', 'output', 'picture', 'q', 'ruby', 's', 'samp', 'small', 'span', 'strong', 'sub', 'sup', 'svg', 'time', 'u', 'var', 'video']
 
-export default function vue(options: NuxtESLintConfigOptions): Linter.Config[] {
+export default async function vue(options: NuxtESLintConfigOptions): Promise<Linter.Config[]> {
   const resolved = resolveOptions(options)
   const hasTs = resolved.features.typescript !== false
 
+  const parser = hasTs
+    ? await import('./typescript').then(mod => mod.parserTs)
+    : undefined
+
   const {
     indent = 2,
     commaDangle = 'always-multiline',
@@ -30,7 +32,7 @@ export default function vue(options: NuxtESLintConfigOptions): Linter.Config[] {
         parserOptions: {
           ecmaVersion: 'latest',
           extraFileExtensions: ['.vue'],
-          parser: hasTs ? parserTs : undefined,
+          parser,
           sourceType: 'module',
           ecmaFeatures: {
             jsx: true,