This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix: sanitize rollup-generated filenames #1648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12606
reverts #477
β Type of change
π Description
This PR removes characters from rollup filenames that are excluded from valid URLs (see RFC 2396). As rollup-produced files may be consumed by browsers, this is one approach to provide broader ecosystem safety without requiring URL encoding.
I've also proposed this in a PR directly to rollup but there may be legitimate reasons for closing it, as this is relevant specifically to browsers rather than the node ecosystem. If accepted we can remove the implementation in this PR.
(Having said that I have also implemented for nitro as I feel most of these characters may also pose problems for filesystems, and in a worker target the filenames may also become URLs.)
π Checklist