Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): Build fails with SSR turned off #2652

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Conversation

blazmrak
Copy link
Contributor

@blazmrak blazmrak commented Jan 9, 2022

πŸ”— Linked issue

nuxt/bridge#27

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Taken out ssr guard for building a server. Build now uses ssr setting from nuxt.config, default remains true.

This solves failing builds when ssr is set to false in nuxt.config.

Fixes nuxt/bridge#27

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jan 9, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: f8130c3

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61ddc95b0cf48000083e0142

@rodrigogs
Copy link

πŸ‘€

@blazmrak blazmrak changed the title fix(nuxi build): Build fails with SSR turned off fix(vite): Build fails with SSR turned off Jan 10, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@pi0 pi0 merged commit e0fec80 into nuxt:main Jan 13, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with SSR turned off
4 participants