-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(nuxt): support vue runtime compiler #4762
feat(nuxt): support vue runtime compiler #4762
Conversation
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
e897d31
to
905b3b6
Compare
Hi @huang-julien and thanks for this PR! π I think finally we can add an option to nitro if modification of commonJS plugin options is required. I hope we can add runtime support with lighter dependencies. At least having (BTW: You don't need to merge into main on each commit. I will make once rebase before merge) |
Hi @pi0 π , yes i was thinking about a PR on Nitro to add the option for the commonjs plugin modification instead of just replacing it in the nuxt package. Do you want me to remove the @vue/devtool-api from the bundle through a commit ? |
linked PR - nitrojs/nitro#187 |
31535eb
to
7095f92
Compare
Client builds with runtime compiler now supports webpack and the runtimeCompiler option is now under the vue namespace in packages/schema/src/config/_app.ts |
What's the status of this PR? Would be awesome to use the runtime compiler soon! |
@tobiasdiez if you really need it now, this module can enable it |
investigating nuxt/nuxt#13843 |
fixed nuxt/nuxt#13843 |
Thank you! It would be nice to document this option somewhere since it is quite useful for CMS integrations using the template prop (see linked issue). Also, is there a place where we can add a test case for this? |
I am thinking of a test case here: https://github.com/nuxt/framework/tree/main/test Any guidance for the best place for it? @danielroe @pi0 |
Testing requires making another fixture currently we only have one. We can add later. I'm pending to locally test this PR. Some changes can be probably reduced for mocking and saving bundle size with option enabled. In the meantime you can use nuxt-runtime-compiler module |
can't find why CI are failing π€·ββοΈ I can't see logs while it does work locally. I'm not even sure if the issue comes from estree walker |
Hi! I'm the autofix.ci troubleshooter bot. It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I've tested on an external project as well, and all seems good. Very happy to iterate over v3.4 releases and then make stable in vue.runtimeCompiler
in v3.5.
Thank you so much for your lengthy and good work on this β€οΈ
π Linked issue
resolve nuxt/nuxt#13843
β Type of change
π Description
This PR allow to use vue runtimeCompiler on both server and client side
π Checklist