-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(schema, vite)!: enable vite-node
by default
#6217
Conversation
β Deploy Preview for nuxt3-docs canceled.
|
This will broke all guys which use docker for develop in Nuxt: |
Thanks for the notice @misaon. Do you mind creating a new issue for vite-node+docker with your docker[compose] file to reproduce? |
@pi0 I can create a sandbox where the bug can be simulated. However, as has already been written in the thread, the bug manifests itself randomly. It doesn't seem to have an obvious cause, it's just that during development (editing components, pages, composables) a situation arises where the bug appears. In our team, where we develop in Docker projects built on Nuxt, the problem happens randomly to everyone. We have found that if this error appears in the console, we have to make a change in some vue file (sometimes several times) to get the watcher to start again and work properly. We use the simplest form of Dockerfile FROM node:18.6.0-alpine3.15 as nuxtBuild
WORKDIR /app
COPY ./ ./
RUN yarn install \
&& yarn run build
FROM node:18.6.0-alpine3.15
ENV HOST=0.0.0.0
WORKDIR /app
COPY --from=nuxtBuild /app/.output /app/.output It is possible that this is the fault of the Alpine distribution itself, but it is on this distribution that NodeJS officially publishes its docker images. |
I can confirm the same issue. It seems not even limited to docker but any Linux/Windows env, HMR watcher is ignored for server and only applied to the client, therefore, having hydration mismatch. I've converted PR to draft until we solve this. ~> nuxt/nuxt#14469 It might be related to issue nuxt/nuxt#12822 since now client HMR on linux works and Server not (in current nuxt, it is otherwise). But also trying |
Good work @pi0! β€οΈ |
vite-node
by defaultvite-node
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at current status. I cannot reproduce (at least stabily) HMR issues. I think we can move it forward to test on edge until next rc.
π Linked issue
nuxt/nuxt#13994
β Type of change
π Description
π Checklist