This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): pass relative url as default base #6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
|
LGTM. Shall we only make a reproduction to report in upstream for handling unhandled cases for renderBuiltUrl or is it impossible in some? |
pi0
approved these changes
Aug 15, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14564
❓ Type of change
📚 Description
Interestingly, vite does not always use
renderBuiltUrlbut sometimes checks.baseby itself. This sets a relative base as the default, which will mean that vite-inserted link preloads will point to the correct location with a dynamic base.📝 Checklist