This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(nuxt): allow programmatically prefetching global components #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
enhancement
New feature or request
components
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
labels
Aug 16, 2022
β Deploy Preview for nuxt3-docs canceled.
|
7 tasks
pi0
reviewed
Aug 16, 2022
pi0
reviewed
Aug 16, 2022
pi0
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As discussed with @danielroe we should iterate over this to make use of build manifest to generate actual <link>
tags and also implement server-side rendering hints (currently not needed with #6876)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
components
enhancement
New feature or request
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#14584
β Type of change
π Description
This adds a new hook (components:prefetch
) that allows prefetching of global components (Pascal case required, to avoid runtime addition of scule utility). We could also expose a utility likenuxtApp.prefetch
or standaloneprefetchComponent
that uses this hook under the hood.This PR exposes new
preloadComponents
utility that allows prefetching of global components (Pascal case required, to avoid runtime addition of scule utility).Also an alias
prefetchComponents
is exposed which does same aspreloadComponents
but as we progress to make better implementation based on manifest maps, users can already opt-in to use semantically write utility.π Checklist