Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt): exclude page chunks from being prefetched #6662

Merged
merged 3 commits into from
Aug 16, 2022
Merged

feat(nuxt): exclude page chunks from being prefetched #6662

merged 3 commits into from
Aug 16, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nuxt/nuxt#14584

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This excludes page chunks from being prefetched within HTML, as these can be managed specifically via vue-router + NuxtLink. (And possibly even handled via nitro prerenderer: nuxt/nuxt#13482.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request pages 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Aug 16, 2022
@danielroe danielroe requested a review from pi0 August 16, 2022 07:50
@danielroe danielroe self-assigned this Aug 16, 2022
@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit df867d8
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fb50351686a80009fceeac

@danielroe danielroe mentioned this pull request Jan 19, 2023
Open
7 tasks
@danielroe danielroe changed the title feat(pages): exclude page chunks from being prefetched feat(nuxt): exclude page chunks from being prefetched Aug 16, 2022
pi0
pi0 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Testing locally before merging.

@pi0 pi0 merged commit 94214d6 into main Aug 16, 2022
@pi0 pi0 deleted the feat/page-prefetching branch August 16, 2022 11:19
@pi0 pi0 mentioned this pull request Aug 16, 2022
Merged
@danielroe danielroe mentioned this pull request Aug 18, 2022
Closed
@pi0 pi0 mentioned this pull request Aug 26, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0