Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(schema): update resolver for cssSourceMap to new sourcemap #7541

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(schema): update resolver for cssSourceMap to new sourcemap #7541

merged 1 commit into from
Sep 15, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should only affect typings for Bridge, but we hadn't updated the get('sourcemap') call.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 15, 2022
@danielroe danielroe requested a review from pi0 September 15, 2022 09:03
@danielroe danielroe self-assigned this Sep 15, 2022
@netlify
Copy link

netlify bot commented Sep 15, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit f18f98d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6322ea66f91aa60008894f0c

@pi0 pi0 added the bridge label Sep 15, 2022
pi0
pi0 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to split v2 schema resolution in next versions and move it to bridge directly...

@pi0 pi0 merged commit b2f147d into main Sep 15, 2022
@pi0 pi0 deleted the fix/css-sourcemap-default branch September 15, 2022 11:10
@pi0 pi0 mentioned this pull request Sep 15, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bridge bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0