Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(schema): evaluate env variables when resolving values #8079

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15123

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously we were evaluating the default values when the @nuxt/schema module was evaluated. But when we are using dotenv we mutate process.env later on. So this makes sure that the app env variables can be updated.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working schema labels Oct 10, 2022
@danielroe danielroe self-assigned this Oct 10, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 10, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 10, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 0e1aec9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6343da4eae5d3d00099d7ab5

@danielroe danielroe changed the title fix(nuxi): read in .env before evaluating schema fix(schema): evaluate env variables when resolving values Oct 10, 2022
@danielroe danielroe requested a review from atinux October 10, 2022 09:39
@danielroe danielroe merged commit e94c3b3 into main Oct 10, 2022
@danielroe danielroe deleted the fix/build-env branch October 10, 2022 10:04
@danielroe danielroe mentioned this pull request Oct 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a baseURL causes Nuxi Generate to not generate html files in ./output/public
2 participants