You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π Documentation (updates to the documentation or readme)
π Bug fix (a non-breaking change that fixes an issue)
π Enhancement (improving an existing functionality like performance)
β¨ New feature (a non-breaking change that adds functionality)
β οΈ Breaking change (fix or feature that would cause existing functionality to change)
π Description
This reverts #7386. Rather than attempt to lazy load the entry CSS, it's safer to rely on browser fetching it in the previous (blocking) manner. We still experience the benefit of inlining SFC styles and we can reconsider entry CSS inlining in future.
Hi there guys, the experimental inlineSSRStyles is still present in rc-13nuxt-config-schema, even says it's true by default on hover, but it does not do the inline at all. This is way confusing.
I think the inline is a really nice feature, and can be leaved here on the toolset as an opt-in feature.
I mean, if you have pretty much < 15 kb css in every page with Tailwindcss, why to block the render of the page awaiting the stylesheet it's fetch, when all that tiny css can be "easily" inlined in the Document Head.
Hi there guys, the experimental inlineSSRStyles is still present in rc-13nuxt-config-schema, even says it's true by default on hover, but it does not do the inline at all. This is way confusing.
I think the inline is a really nice feature, and can be leaved here on the toolset as an opt-in feature. I mean, if you have pretty much < 15 kb css in every page with Tailwindcss, why to block the render of the page awaiting the stylesheet it's fetch, when all that tiny css can be "easily" inlined in the Document Head.
I agree in some cases, it still makes sense to inline the global CSS. Is there a way to force this to happen in the current configuration?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.xbugSomething isn't workingπ¨ p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#14953
β Type of change
π Description
This reverts #7386. Rather than attempt to lazy load the entry CSS, it's safer to rely on browser fetching it in the previous (blocking) manner. We still experience the benefit of inlining SFC styles and we can reconsider entry CSS inlining in future.
π Checklist